Modify AuditReplay workflow to output count and latency of operations#92
Merged
Conversation
xkrogen
reviewed
Mar 14, 2019
xkrogen
left a comment
xkrogen
left a comment
Collaborator
There was a problem hiding this comment.
Can we change the TextOutputFormat.SEPERATOR config to be a , so that we end up with CSV output instead of half-CSV, half-tabulated?
Other than that, and my minor comments, LGTM
added 2 commits
March 14, 2019 12:18
Contributor
Author
|
Fixed up, edited PR to match. |
xkrogen
reviewed
Mar 14, 2019
xkrogen
left a comment
xkrogen
left a comment
Collaborator
There was a problem hiding this comment.
Few more minor comments
csgregorian
force-pushed
the
count_and_time
branch
from
668c3b7 to
25e9d3e
Compare
Contributor
Author
|
Fixed up 👍 |
xkrogen
reviewed
Mar 14, 2019
This was referenced Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a composite output type,
CountTimeWritable, to track the count in addition to the cumulative time of operations. As well, adds another level of granularity through the operation name instead of just the type. This gives more insight into per-operation behaviour, and makes it possible to calculate the average latency per operation instead of just the total.EDIT: also changes the separator to a
,for better tabular representationThe output from a workflow changes as follows:
Before
After